Skip to content

Conversation

@cmangeat
Copy link
Contributor

@cmangeat cmangeat commented Oct 31, 2025

This PR is about improving STAC collection harvester (stac-to-iso19115-3.xsl conversion): add an online resource and cit:identifier for doi when available. (You can try it with stac collection like https://stacapi-cdos.apps.okd.crocc.meso.umontpellier.fr/collections, the stac harvester is a "URL simple" harvester, there is a "STAC collection" example configuration in harvester configuration panel).

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation
  • Funded by INRAE

Copy link
Member

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks! I made a comment but I think your approach is valid.

<cit:identifier>
<mcc:MD_Identifier>
<mcc:code>
<gcx:Anchor xlink:href="{concat('https://doi.org/', sci_doi)}"><xsl:value-of select="sci_doi"/></gcx:Anchor>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extension that this field comes from (https://github.com/stac-extensions/scientific) says that a cite-as link should be present in the collection as well and give us a link to the actual DOI, without having to assemble this link ourselves. But in the sample used for the test this link doesn't exist, so I guess your approach is safer.

@cmangeat cmangeat marked this pull request as ready for review December 2, 2025 10:56
@cmangeat cmangeat mentioned this pull request Dec 7, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants